Skip to content

Fixed a bug#581

Closed
woshigelaji wants to merge 1 commit into
tirth8205:mainfrom
woshigelaji:main
Closed

Fixed a bug#581
woshigelaji wants to merge 1 commit into
tirth8205:mainfrom
woshigelaji:main

Conversation

@woshigelaji

Copy link
Copy Markdown

Fixed a bug where daemon wrote an invalid TOML (Invalid hex value) when saving configurations on Windows due to unescaped backslash paths, causing configuration reloading.

…en saving configurations on Windows due to unescaped backslash paths, causing configuration reloading.
@tirth8205

Copy link
Copy Markdown
Owner

Closing as superseded by the independently implemented Windows daemon fix merged in #632 (merge commit 94da74e).\n\nExact overlap:\n- PR #581 escapes backslashes, double quotes, and U+0000–U+001F control characters before writing daemon TOML.\n- Current main now applies the same required TOML escaping to session_name, log_dir, repo path, and alias.\n- The merged implementation is slightly stricter: it also escapes U+007F, which TOML forbids unescaped.\n- Current regression tests parse Windows backslash paths and quoted values through tomllib, and the dedicated Windows CI job passed after merge.\n\nBecause the production fix was implemented independently through #632, no code from #581 was copied and I am not claiming contributor attribution for the merged implementation. The reported bug itself is resolved on main, so there is no remaining change to merge from this branch.

@tirth8205 tirth8205 closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants